On Friday, September 9, 2016, Ryan Schmidt <<a href="mailto:ryandesign@macports.org">ryandesign@macports.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
> On Sep 8, 2016, at 11:28 PM, <a href="javascript:;" onclick="_e(event, 'cvml', 'eborisch@macports.org')">eborisch@macports.org</a> wrote:<br>
><br>
> Revision<br>
> 152440<br>
> Author<br>
> <a href="javascript:;" onclick="_e(event, 'cvml', 'eborisch@macports.org')">eborisch@macports.org</a><br>
> Date<br>
> 2016-09-08 21:28:04 -0700 (Thu, 08 Sep 2016)<br>
> Log Message<br>
><br>
> zabbix3: New port.<br>
<br>
<br>
> Added Paths<br>
><br>
> • trunk/dports/net/zabbix3/<br>
<br>
<br>
> + --with-gnutls=/opt/local \<br>
> + --enable-ipv6<br>
<br>
Surely that should be "${prefix}" not "/opt/local"?<br>
<br>
<br>
> + eval xinstall -m 755 -W ${worksrcpath}/database/${<wbr>DBFILES} \<br>
> + data.sql images.sql schema.sql \<br>
> + ${destroot}${prefix}/share/<wbr>zabbix/scripts<br>
<br>
It doesn't look like this needs eval -- I don't see a list. If a list were being used, the expansion operator ("{*}") should be used instead of eval.<br>
</blockquote><div><br></div><div>Yes on both parts. <span></span>Thanks for catching those; I'll clean them up.</div><div><br></div><div> - Eric</div>