[MacPorts] #12013: "port upgrade" tries to activate an installed version before building the new version

[MacPorts]

#12013: "port upgrade" tries to activate an installed version before building the
new version
----------------------------------+-----------------------------------------
  Reporter:  vinc17 at macports.org  |       Owner:  eridius at macports.org
      Type:  defect               |      Status:  assigned            
  Priority:  Normal               |   Milestone:  MacPorts 1.6.1      
 Component:  base                 |     Version:  1.4.42              
Resolution:                       |    Keywords:                      
----------------------------------+-----------------------------------------
Changes (by jmr at macports.org):

 * cc: vinc17 at macports.org, eridius at macports.org (removed)
 * cc: jmr at macports.org (added)
  * milestone:  MacPorts base bugs => MacPorts 1.6.1

Comment:

 The comment
 [http://trac.macports.org/browser/trunk/base/src/macports1.0/macports.tcl#L1942
 here] says that upgrade will deactivate any active version of the port
 before activating the latest installed version. The code to do that is
 broken though. The test around the deactivate call is always false, and
 the deactivate call itself doesn't use the full version spec (which would
 cause it to fail if it were ever actually reached).

 The purpose of testing at all instead of just deactivating whatever's
 active seems to be to avoid deactivating if the latest version is already
 the one that is active. The attached patch should hopefully make this work
 as intended.

 I'm also proposing this for the 1.6.1 milestone.

-- 
Ticket URL: <http://trac.macports.org/ticket/12013#comment:7>
MacPorts </>
Ports system for Mac OS