[MacPorts] #23456: use_dmg yes fails when worksrcdir contains a space

[MacPorts]

#23456: use_dmg yes fails when worksrcdir contains a space
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  ryandesign@…           
     Type:  defect                   |      Status:  new                    
 Priority:  Normal                   |   Milestone:  MacPorts 1.8.3         
Component:  base                     |     Version:  1.8.2                  
 Keywords:                           |        Port:                         
-------------------------------------+--------------------------------------

Comment(by ryandesign@…):

 Replying to [comment:1 ryandesign@…]:
 > So I need some other eyes to look at this and see if there are any
 problems with my proposed changes before I commit them

 There are, exemplified by bzip2. Clearly my patch botches something. With
 patch, broken:

 {{{
 --->  Building bzip2
 DEBUG: build phase started at Thu Feb 18 00:09:41 CST 2010
 DEBUG: Executing proc-pre-org.macports.build-build-0
 DEBUG: Executing org.macports.build (bzip2)
 DEBUG: Environment: CPATH='/opt/local/include'
 CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work/.CC_PRINT_OPTIONS'
 LIBRARY_PATH='/opt/local/lib' CC_PRINT_OPTIONS='YES'
 MACOSX_DEPLOYMENT_TARGET='10.6'
 DEBUG: Assembled command: 'cd
 "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work/bzip2-1.0.5"
 && /usr/bin/nice -n 10 /usr/bin/make all CC=\"/usr/bin/gcc-4.2 {-arch
 x86_64"} PREFIX=/opt/local'
 sh: -c: line 0: unexpected EOF while looking for matching `"'
 sh: -c: line 1: syntax error: unexpected end of file
 }}}

 Without patch, works fine:

 {{{
 --->  Building bzip2
 DEBUG: build phase started at Thu Feb 18 00:10:57 CST 2010
 DEBUG: Executing proc-pre-org.macports.build-build-0
 DEBUG: Executing org.macports.build (bzip2)
 DEBUG: Environment: CPATH='/opt/local/include'
 CC_PRINT_OPTIONS_FILE='/opt/local/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work/.CC_PRINT_OPTIONS'
 LIBRARY_PATH='/opt/local/lib' CC_PRINT_OPTIONS='YES'
 MACOSX_DEPLOYMENT_TARGET='10.6'
 DEBUG: Assembled command: 'cd
 "/opt/local/var/macports/build/_Users_rschmidt_macports_dports_archivers_bzip2/work/bzip2-1.0.5"
 && /usr/bin/nice -n 10 /usr/bin/make all CC="/usr/bin/gcc-4.2 -arch
 x86_64" PREFIX=/opt/local'
 }}}

-- 
Ticket URL: <http://trac.macports.org/ticket/23456#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS