[MacPorts] #24258: Gramps version 3.2.0 Please commit

MacPorts noreply at macports.org
Sun Mar 28 12:22:23 PDT 2010


#24258: Gramps version 3.2.0 Please commit
----------------------------------+-----------------------------------------
 Reporter:  guy.linton@…          |       Owner:  macports-tickets@…                   
     Type:  update                |      Status:  new                                  
 Priority:  Normal                |   Milestone:                                       
Component:  ports                 |     Version:  1.8.2                                
 Keywords:                        |        Port:  Gramps                               
----------------------------------+-----------------------------------------

Comment(by ryandesign@…):

 In future, please submit unified diffs, not complete portfiles, and ensure
 that the diff only makes changes that are relevant to the task at hand;
 don't also make unrelated changes, such as whitespace changes.

 The $Id$ line in your new portfile indicates revision
 [browser:trunk/dports/gnome/gramps/Portfile at 28793 28793]; I thus assume
 you based your new version on that old version. You should base your
 changes on the very latest version of a portfile, in this case
 [browser:trunk/dports/gnome/gramps/Portfile at 51955 51955]. In this case,
 for example, your "new" portfile undoes changes made to this port
 previously, such as the livecheck fix from r42705 and the dependency
 removal from r51955. (Granted, the livecheck doesn't currently work right
 either way.) Your changes to the description also introduce a typo
 (advised => adviced).

 I've attached a patch which I believe expresses your intent in upgrading
 the port without the other changes. It installs OK for me on Snow Leopard.
 I have asked for confirmation from rjt about giving up maintainership of
 this port; waiting to hear back before committing.

-- 
Ticket URL: <http://trac.macports.org/ticket/24258#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list