[MacPorts] #30278: Can qt4-mac-devel be updated to Qt 4.8.0 beta?
MacPorts
noreply at macports.org
Sun Aug 7 14:09:36 PDT 2011
#30278: Can qt4-mac-devel be updated to Qt 4.8.0 beta?
-----------------------------------+----------------------------------------
Reporter: trojanfoe@… | Owner: michaelld@…
Type: update | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: | Port: qt4-mac-devel
-----------------------------------+----------------------------------------
Comment(by rmstonecipher@…):
Replying to [comment:9 carsomyr@…]:
> Trojan, I think the reason for the patch failure is because qt4-mac is a
moving target. In any case, I've uploaded an updated Port patch archive.
I've also uploaded the qt4-mac-devel Port archive for those who don't want
to apply patches.
Roy,[[br]]
I tried testing your archive of qt4-mac-devel but came up with some
UsingTheRightCompiler errors.[[br]]
The Portfile uses reinplace to replace "g++" and "gcc" with
${configure.cc}, but the files in which the substitution would occur have
been deprecated.[[br]][[br]]
The following change to the Portfile fixes the error but is not the best
solution:
{{{
@@ -120,5 +120,9
# Ensure that correct C/C++ compilers are used.
- reinplace "s| g++\$| ${configure.cxx}|" \
- ${worksrcpath}/mkspecs/common/g++.conf
- reinplace "s| gcc\$| ${configure.cc}|" \
- ${worksrcpath}/mkspecs/common/g++.conf
+ reinplace "s| g++\$| ${configure.cxx}|" \
+ ${worksrcpath}/mkspecs/common/g++-base.conf
+ reinplace "s| g++\$| ${configure.cxx}|" \
+ ${worksrcpath}/mkspecs/common/g++-unix.conf
+ reinplace "s| gcc\$| ${configure.cc}|" \
+ ${worksrcpath}/mkspecs/common/g++-base.conf
+ reinplace "s| gcc\$| ${configure.cc}|" \
+ ${worksrcpath}/mkspecs/common/g++-unix.conf
}}}
I am unsure of whether g++-base.conf or g++-unix.conf is used for
Mac.[[br]][[br]]
It would be better to use a patch to substitute a placeholder (e.g.
"%%CONFIGURE.CC%%") in files which call "g++" or "gcc".[[br]]
This placeholder could then be reinplace'd post-patch with
"${configure.cc}".[[br]]
If something changes upstream and the patch cannot be applied the
maintainer can determine if (1) the patch is no longer necessary or (2)
the patch needs to be updated to point to different files and/or
lines.[[br]][[br]]
Cheers,[[br]]
Ryan Stonecipher
--
Ticket URL: <https://trac.macports.org/ticket/30278#comment:13>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list