[MacPorts] #29707: git-core 1.7.5.3 fails to install doc if build and destroot run as separate commands

MacPorts noreply at macports.org
Sun Jul 3 16:46:50 PDT 2011


#29707: git-core 1.7.5.3 fails to install doc if build and destroot run as separate
commands
---------------------------+------------------------------------------------
 Reporter:  mta@…          |       Owner:  macports-tickets@…                   
     Type:  defect         |      Status:  new                                  
 Priority:  Normal         |   Milestone:  MacPorts Future                      
Component:  base           |     Version:  1.9.99                               
 Keywords:                 |        Port:                                       
---------------------------+------------------------------------------------
Changes (by raimue@…):

 * cc: raimue@… (added)
  * port:  git-core =>
  * milestone:  => MacPorts Future


Comment:

 I agree that this is a bug. Thank you for catching this.

 I am not quite happy yet with the solution in the patch. I would remove
 the redundancy in fetch/extract. Defining options like this at multiple
 places will lead to diversity. A future developer might not be aware of
 the redundancy at all. I am also not convinced of moving the definition of
 the extract.* options to fetch as they do not belong there.

 A better solution could be developed using lazy evaluation as we do it for
 the configure phase:
 {{{
 default extract.cmd            {[portextract::extract_get_cmd]}
 }}}
 This will be evaluated when `extract.cmd` will be read the first time.

-- 
Ticket URL: <https://trac.macports.org/ticket/29707#comment:2>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list