[MacPorts] #28678: fossil: universal, build_arch, compiler

[MacPorts]

#28678: fossil: universal, build_arch, compiler
-------------------------------------+--------------------------------------
 Reporter:  ryandesign@…             |       Owner:  ciserlohn@…             
     Type:  defect                   |      Status:  new                     
 Priority:  Normal                   |   Milestone:                          
Component:  ports                    |     Version:  1.9.2                   
 Keywords:                           |        Port:  fossil                  
-------------------------------------+--------------------------------------

Comment(by ciserlohn@…):

 Replying to [comment:4 ryandesign@…]:

 Thanks for the helpful hints.
 [[BR]]
 [[BR]]
 > Replying to [comment:3 ciserlohn@…]:
 > > I left out the universal variant intentionally because i can't test
 the universal variant (no PPC machine). But otherwise it seems ok to me.
 >
 > Universal doesn't necessarily mean ppc and i386. On Snow Leopard, by
 default, it means i386 and x86_64. I verified it built ok on Snow Leopard
 for i386 and x86_64, so unless you have specific information about a build
 or runtime failure with universal on some system, we should add the
 universal variant.
 [[BR]]
 I see. Maybe the documentation should be updated:
 ----
 5.3.7.1. Configure Universal

 Universal keywords are used to make a port compile on the Mac OS X
 platform to run on both PPC and Intel processors.

 ----
 You can figure out that this don't hold true for Snow Leopard from the
 details of the various configure.universal_* flags. But it is a bit
 confusing for newbies.
 [[BR]][[BR]]


 > > I am not quite sure about the patch to the Makefile. Since it is
 generated by makemake.tcl it should be patched afterwards. This should be
 more robust.
 >
 > If that's the case, then it should be a patchfile for makemake.tcl.
 Patchfiles should be preferred to reinplaces, especially when there is no
 variable content that needs to be inserted at build time, and only a few
 lines of changes. I tested my patch before attaching it here, and it
 worked correctly, i.e., it made the port build with "/usr/bin/gcc-4.2"
 instead of "gcc", and the build completed. I guess that means makemake.tcl
 simply didn't regenerate the Makefile for me, perhaps because the Makefile
 was newer due to the patch?
 [[BR]]
 Looked again at makemake.tcl and the build process. It does not generate
 the makefile - at least on *nix systems. It does generate it on windows
 systems. On *nix systems it generates src/main.mk, which gets included by
 the makefile but does not have a reference to 'gcc'.  So patching the
 makefile should be safe.

 Could you please apply your proposed patch?

-- 
Ticket URL: <https://trac.macports.org/ticket/28678#comment:5>
MacPorts <http://www.macports.org/>
Ports system for Mac OS