[MacPorts] #28850: mod_mono builds with old problem

MacPorts noreply at macports.org
Mon Mar 21 01:19:47 PDT 2011


#28850: mod_mono builds with old problem
-----------------------------+----------------------------------------------
 Reporter:  vulcan_@…        |       Owner:  macports-tickets@…                   
     Type:  defect           |      Status:  new                                  
 Priority:  Normal           |   Milestone:                                       
Component:  ports            |     Version:  1.9.2                                
 Keywords:                   |        Port:  mod_mono                             
-----------------------------+----------------------------------------------

Comment(by vulcan_@…):

 == '''ah ha!!''' ==
 looking at the code in mod_mono.c
 {{{
 static int
 connection_get_remote_port (conn_rec *c)
 {
 #ifdef APACHE13
         return  ntohs (c->remote_addr.sin_port);
 #elif defined(APACHE22)
         return c->remote_addr->port;
 #else
         apr_port_t port;
         apr_sockaddr_port_get (&port, c->remote_addr);
         return port;
 #endif

 }
 }}}

 we can see that the deprecated apr_sockaddr_port_get() should not be
 called ... IFF APACHE22 is defined, which is obviously is not.
 This starts to smell like a portfile fix is needed to add a -DAPACHE22 to
 the compile commands

-- 
Ticket URL: <https://trac.macports.org/ticket/28850#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list