[MacPorts] #34247: libcdio 0.83 misses osx driver in Lion and possibly Snow Leopard

[MacPorts]

#34247: libcdio 0.83 misses osx driver in Lion and possibly Snow Leopard
---------------------------------+------------------------------------------
 Reporter:  claunia@…            |       Owner:  macports-tickets@…                   
     Type:  defect               |      Status:  new                                  
 Priority:  Normal               |   Milestone:                                       
Component:  ports                |     Version:  2.0.4                                
 Keywords:  haspatch             |        Port:  libcdio                              
---------------------------------+------------------------------------------
Changes (by ryandesign@…):

  * keywords:  => haspatch
  * port:  => libcdio


Old description:

> libcdio 0.83 default configure misses osx driver because a bad search in
> configure script.
>
> zeus:~ claunia$ time sudo port install libcdio
> Warning: port definitions are more than two weeks old, consider using
> selfupdate
> --->  Computing dependencies for libcdio
> --->  Dependencies to be installed: libcddb
> --->  Fetching archive for libcddb
> --->  Attempting to fetch libcddb-1.3.2_1.darwin_11.x86_64.tbz2 from
> http://packages.macports.org/libcddb
> --->  Attempting to fetch libcddb-1.3.2_1.darwin_11.x86_64.tbz2.rmd160
> from http://packages.macports.org/libcddb
> --->  Installing libcddb @1.3.2_1
> --->  Activating libcddb @1.3.2_1
> --->  Cleaning libcddb
> --->  Fetching archive for libcdio
> --->  Attempting to fetch libcdio-0.83_0.darwin_11.x86_64.tbz2 from
> http://packages.macports.org/libcdio
> --->  Attempting to fetch libcdio-0.83_0.darwin_11.x86_64.tbz2.rmd160
> from http://packages.macports.org/libcdio
> --->  Installing libcdio @0.83_0
> --->  Activating libcdio @0.83_0
> --->  Cleaning libcdio
>
> zeus:~ claunia$ cd-drive
> cd-drive version 0.83 x86_64-apple-darwin11.3.0
> Copyright (c) 2003, 2004, 2005, 2007, 2008, 2011 R. Bernstein
> This is free software; see the source for copying conditions.
> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
> PARTICULAR PURPOSE.
> No loaded CD-ROM device accessible.
> Drivers available...
>   cdrdao (TOC) disk image driver
>   bin/cuesheet disk image driver
>   Nero NRG disk image driver
>
> Problem comes from line #16678 in configure script, it says:
> ''darwin6*|darwin7*|darwin8*|darwin9*)''
> missing darwin10 (Mac OS X 10.6) and darwin11 (Mac OS X 10.7)
>
> changing it to
> ''darwin6*|darwin7*|darwin8*|darwin9*|darwin10*|darwin11*)''
> makes configure to try to use the osx driver:
> ''configure:
> Using CD-ROM drivers : cdrdao, BIN/CUE, NRG, Darwin''
>
> But then a change needs to be done on osx.c file.
>
> I have checked with OS X 10.4, 10.5 and 10.6 SDKs and the same changes
> that apply to 10.7 should apply to them.
>
> Also if the only present drive is a bluray one, it is not detected.
> (Simply adding IOBDMediaClass to the search is not working, I'm
> investingating).
>
> I have attached a patch, and will send the same bug to libcdio
> mainstream.

New description:

 libcdio 0.83 default configure misses osx driver because a bad search in
 configure script.

 {{{
 zeus:~ claunia$ time sudo port install libcdio
 Warning: port definitions are more than two weeks old, consider using
 selfupdate
 --->  Computing dependencies for libcdio
 --->  Dependencies to be installed: libcddb
 --->  Fetching archive for libcddb
 --->  Attempting to fetch libcddb-1.3.2_1.darwin_11.x86_64.tbz2 from
 http://packages.macports.org/libcddb
 --->  Attempting to fetch libcddb-1.3.2_1.darwin_11.x86_64.tbz2.rmd160
 from http://packages.macports.org/libcddb
 --->  Installing libcddb @1.3.2_1
 --->  Activating libcddb @1.3.2_1
 --->  Cleaning libcddb
 --->  Fetching archive for libcdio
 --->  Attempting to fetch libcdio-0.83_0.darwin_11.x86_64.tbz2 from
 http://packages.macports.org/libcdio
 --->  Attempting to fetch libcdio-0.83_0.darwin_11.x86_64.tbz2.rmd160 from
 http://packages.macports.org/libcdio
 --->  Installing libcdio @0.83_0
 --->  Activating libcdio @0.83_0
 --->  Cleaning libcdio

 zeus:~ claunia$ cd-drive
 cd-drive version 0.83 x86_64-apple-darwin11.3.0
 Copyright (c) 2003, 2004, 2005, 2007, 2008, 2011 R. Bernstein
 This is free software; see the source for copying conditions.
 There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
 PARTICULAR PURPOSE.
 No loaded CD-ROM device accessible.
 Drivers available...
   cdrdao (TOC) disk image driver
   bin/cuesheet disk image driver
   Nero NRG disk image driver
 }}}

 Problem comes from line 16678 in configure script, it says:
 {{{
 darwin6*|darwin7*|darwin8*|darwin9*)
 }}}
 missing darwin10 (Mac OS X 10.6) and darwin11 (Mac OS X 10.7)

 changing it to
 {{{
 darwin6*|darwin7*|darwin8*|darwin9*|darwin10*|darwin11*)
 }}}
 makes configure to try to use the osx driver:
 {{{
 configure:
 Using CD-ROM drivers : cdrdao, BIN/CUE, NRG, Darwin
 }}}

 But then a change needs to be done on osx.c file.

 I have checked with OS X 10.4, 10.5 and 10.6 SDKs and the same changes
 that apply to 10.7 should apply to them.

 Also if the only present drive is a bluray one, it is not detected.
 (Simply adding IOBDMediaClass to the search is not working, I'm
 investingating).

 I have attached a patch, and will send the same bug to libcdio mainstream.

--

Comment:

 I guess we might as well add a case for Mountain Lion as well since that's
 coming up before too long.

-- 
Ticket URL: <https://trac.macports.org/ticket/34247#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS