[MacPorts] #35728: gsoap: update to version to 2.8.9 and patch header macro

[MacPorts]

#35728: gsoap: update to version to 2.8.9 and patch header macro
------------------------------------+---------------------------------------
 Reporter:  ajdudman@…              |       Owner:  ryandesign@…           
     Type:  update                  |      Status:  assigned               
 Priority:  Normal                  |   Milestone:                         
Component:  ports                   |     Version:  2.1.99                 
 Keywords:  haspatch                |        Port:  gsoap                  
------------------------------------+---------------------------------------

Comment(by ajdudman@…):

 The patch came from September 9, 2011.  I was reading a webpage by pi-
 pixel for help in building VirtualBox, currently [http://pi-
 pixel.tumblr.com/post/3021724967/how-to-compile-virtualbox-on-snow-
 leopard-with-macports][[BR]]
 As you known macports's gsoap was then version 2.8.3.

 Well the VirtualBox build uses soapcpp2 to generate code.  In particular
 soapC.cpp, which is split into 20 files.  Starting with
 out/darwin.amd64/release/obj/webservice/soapC-4.cpp many use SOAP_NEW
 macro. Please see the end of pi-pixel's webpage for the error he had got,
 and I too got.  Briefly, g++ wrongly parsed that new operator as a
 variable-length array. He had developed a patch for gsoap 2.8.1 and Apple
 gcc build version 5664.  I found it also necessary for gcc build version
 5666 with both gsoap 2.8.1 and 2.8.3 last year.  So I made my one-liner
 patch use critical value 5666 instead, but that is the entirety of the
 patch, with nothing else left for which to give attribution.

 Much has changed in a year.  Snow Leopard and Xcode and VirtualBox all
 updated.  My Xcode is now at 3.2.6.  I am unable to reproduce the error
 with today's VirtualBox-4.2.0-r42789.  Thanks to time machine, I can go
 back to an older VirtualBox.
 Choosing 03 February 2012's VirtualBox-4.1.51-r39985, I can reproduce the
 erred build with an unpatched gsoap, and the correct build with a patched
 gsoap.
 It was never a build time error, nor really a run time error, instead a
 feature to workaround trouble various target compilers will have compiling
 the output code.

 I am sorry for being picky.  Personally, since VirtualBox code has
 advanced, I no longer have a pressing need for this patch.  What ever you
 decide about the need for a patch, please let us still bump the gsoap
 version and specify the license.

 Upstream has an closed bug ID: 3292955  engelen commented[[BR]]
 You need to take a look at the SOAP_NEW macro in stdsoap2.h and change it
 there. SOAP_NEW(type) is either 'new(type)' or 'new type' for portability.

 open bug ID: 3362640 status pending

 open bug ID: 3519393 status open[[BR]]
 Here is the active one.  A patch is being developed which will include the
 SOAP_NEW macro.
 [http://sourceforge.net/tracker/download.php?group_id=52781&atid=468021&file_id=441593&aid=3519393]

-- 
Ticket URL: <https://trac.macports.org/ticket/35728#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS