[MacPorts] #37352: torsocks: Fixes for #36806 and #36807 (was: Fixes for #38606 and #36807)
MacPorts
noreply at macports.org
Thu Dec 20 04:58:09 PST 2012
#37352: torsocks: Fixes for #36806 and #36807
---------------------------+--------------------------------
Reporter: sami.laine@… | Owner: macports-tickets@…
Type: update | Status: new
Priority: Normal | Milestone:
Component: ports | Version: 2.1.2
Resolution: | Keywords: haspatch
Port: torsocks |
---------------------------+--------------------------------
Changes (by ryandesign@…):
* cc: ryandesign@… (added)
* keywords: => haspatch
Old description:
> Updated Portfile for torsocks package, includes fixes for #38606 and
> #38607.
New description:
Updated Portfile for torsocks package, includes fixes for #36806 and
#36807.
--
Comment:
Thank you but this patch has a few problems:
* it mixes whitespace and functional changes
* it introduces your name into the maintainers line, which should only
contain (obfuscated) email addresses
* it changes "OS X" (which is the correct name of the OS) to "Mac OSX"
* it adds a "dist_subdir" line which is unnecessary unless a stealth
update has occurred, which I assume it hasn't since you haven't changed
the checksums
* it removes the license line
* it adds "--prefix=${prefix}" to configure.args which is unnecessary
because MacPorts automatically puts that into configure.pre_args
* it changes master_sites from the simple and recommended googlecode to a
more verbose URL
* it adds an unnecessary "# end of file." comment
--
Ticket URL: <https://trac.macports.org/ticket/37352#comment:1>
MacPorts <http://www.macports.org/>
Ports system for Mac OS
More information about the macports-tickets
mailing list