[MacPorts] #35168: gimp2 build error

[MacPorts]

#35168: gimp2 build error
---------------------------+------------------------------------------------
 Reporter:  rkupke@…       |       Owner:  devans@…           
     Type:  defect         |      Status:  new                
 Priority:  Normal         |   Milestone:                     
Component:  ports          |     Version:  2.1.1              
 Keywords:                 |        Port:  gimp2              
---------------------------+------------------------------------------------

Comment(by drowe@…):

 I have had a deeper look at this.[[BR]]I am not the maintainer and I don't
 know the internal workings of Gimp, but the error report is fairly
 straightforward.

 In
 /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_graphics_gimp2/gimp2/work/gimp-2.8.0
 /plug-ins/twain[[BR]]
 there is a header file: tw_func.h

 The last two lines of this are:[[BR]]
 238: BOOL InitApplication(HINSTANCE hInstance);[[BR]]
 239: BOOL InitInstance(HINSTANCE hInstance, int nCmdShow, pTW_SESSION
 twSession);[[BR]]


 The compile is failing because BOOL and HINSTANCE are undefined.[[BR]]
 Now BOOL is sort of self-describing, so I googled 'HINSTANCE Gimp' and
 various discussions came up - all relating to the Windows version of
 Gimp.[[BR]]
 It seems that HINSTANCE is a windows data structure that an application
 has to use to communicate with Windows.

 My guess is that these two lines should not be operational in the Macports
 version (they should probably inside a '#ifdef' . . #endif'
 conditional).[[BR]]
 So I tried manually commenting out these two lines (directly editing the
 code) and, lo, gimp2.8 completed the build without further errors and it
 produced a binary that seems to run.[[BR]]
 I haven't done an exhaustive test of the features of gimp2.8.[[BR]]
 Actually the Macports version of gimp doesn't seem to support TWAIN
 anyway, so I am not sure what the above twain code is for.

 I am offering this information in the hope that it helps the maintainer
 come up with a proper fix to the port.

 Regards DR

-- 
Ticket URL: <https://trac.macports.org/ticket/35168#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS