[MacPorts] #37031: Toluapp Portfile

MacPorts noreply at macports.org
Sat Nov 17 22:04:19 PST 2012


#37031: Toluapp Portfile
-------------------------------+--------------------------------
  Reporter:  brad.clemetson@…  |      Owner:  macports-tickets@…
      Type:  submission        |     Status:  new
  Priority:  Normal            |  Milestone:
 Component:  ports             |    Version:  2.1.2
Resolution:                    |   Keywords:
      Port:                    |
-------------------------------+--------------------------------

Comment (by ryandesign@…):

 Thanks. Some initial comments:

  * Since this project is hosted at github, please try using the github
 portgroup.
  * A fetch dependency on git-core needn't be added; MacPorts base does so
 for you automatically when fetch.type is git.
    * But if possible, fetch a tarball, not from git.
    * I see there's a tag for 1.0.93; perhaps that's what the version
 should be, and the tarball that should be downloaded.
  * /opt/local should not be hardcoded; use ${prefix} instead.
    * But -DCMAKE_INSTALL_PREFIX needn't be set manually; the cmake
 portgroup sets it for you.
  * In MacPorts we usually replace "+"s in project names with "x"s not
 "p"s.
    * But since the project seems to be referred to as toluapp by upstream
 in a few places already I guess we can keep that name too.

-- 
Ticket URL: <https://trac.macports.org/ticket/37031#comment:4>
MacPorts <http://www.macports.org/>
Ports system for Mac OS


More information about the macports-tickets mailing list