[MacPorts] #43582: surf: variant without x11 doesn't build
MacPorts
noreply at macports.org
Mon May 5 07:28:38 PDT 2014
#43582: surf: variant without x11 doesn't build
---------------------+--------------------------------
Reporter: mojca@… | Owner: macports-tickets@…
Type: defect | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: | Port:
---------------------+--------------------------------
Based on the ticket #39383 I tried to patch `surf`:
{{{
#!diff
Index: Portfile
===================================================================
--- Portfile (revision 119745)
+++ Portfile (working copy)
@@ -26,13 +26,21 @@
port:flex \
port:xorg-libXmu \
port:jpeg \
- port:tiff \
- port:gtk1
+ port:tiff
-variant no_x11 {
- depends_lib-delete port:gtk1
- configure.args-append --disable-gui
+configure.args --disable-gui
+
+# remove this in May 2015
+variant no_x11 conflicts x11 description {legacy compatibility variant}
{}
+variant x11 conflicts no_x11 description {} {
+ depends_lib-append port:gtk1
+ configure.args-delete --disable-gui
}
+if {[variant_isset no_x11]} {
+ default_variants -x11
+} else {
+ default_variants +x11
+}
post-destroot {
copy ${worksrcpath}/examples ${destroot}${prefix}/share/${name}/
}}}
But the problem seems to be that `surf` fails to build without `x11`:
{{{
make[1]: *** No rule to make target `gtkgui/start.o', needed by `surf'.
Stop.
}}}
so I'm wondering whether it makes any sense to provide `x11` as an option
if building without gui support is broken anyway.
I have a few other questions:
* Is flex a build or a runtime dependency?
* If building without `gtk1` would actually work
* Is `xorg-libXmu` still needed?
* Would it be better to call the variant `gtk` or `x11`?
* The binary depends on a few other libraries here, but I'm not sure if
those are true dependencies because I never rebuilt all the ports:
* `glib1`
* `libiconv`
* `zlib`
* `xorg-libX11`
* `xorg-libice`
* `xorg-libsm`
* `xorg-lbXt`
* `xorg-libXext`
* Is it possible to build the port against `gtk2` or `gtk3`?
--
Ticket URL: <https://trac.macports.org/ticket/43582>
MacPorts <http://www.macports.org/>
Ports system for OS X
More information about the macports-tickets
mailing list