[MacPorts] #48078: cantera binary files not executable

[MacPorts]

#48078: cantera binary files not executable
--------------------------+--------------------------
  Reporter:  jjstickel@…  |      Owner:  ryandesign@…
      Type:  defect       |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:  2.3.3
Resolution:               |   Keywords:  haspatch
      Port:  cantera      |
--------------------------+--------------------------
Changes (by ryandesign@…):

 * owner:  macports-tickets@… => ryandesign@…


Comment:

 Replying to [ticket:48078 jjstickel@…]:
 > With the recent version update to cantera (2.2.0), some of the binary
 files are not installed as executable. The attached patch resolves this. I
 did not test with the devel subport.

 The `file attributes` proc should be used instead of using `system` to
 call `chmod`.

 > Also, I found the macports-archived source file to be stale, and the one
 direct from
 https://github.com/Cantera/cantera/releases/download/v2.2.0/cantera-2.2.0.tar.gz
 needed different checksums.

 I do not experience a checksum error with the port as it is currently
 written, but I would experience one if I applied your patch. The port
 currently uses "tarball" style download, whereas the URL you show above is
 a "release" style download, and yes, it is normal that these would have
 different checksums and slightly different contents. The former is
 automatically generated from the repository by the github architecture,
 whereas the second is manually created by the developers and uploaded to
 github.

 It is true that the port should be updated to use the "release" style
 download (by using `github.tarball_from releases`), but unless this
 improves the build of the software in some way, it can wait until the next
 version update.

 If switching to "release" would improve the build, then the
 [wiki:PortfileRecipes#stealth-updates stealth update] recipe must be
 followed.

-- 
Ticket URL: <https://trac.macports.org/ticket/48078#comment:1>
MacPorts <https://www.macports.org/>
Ports system for OS X