[MacPorts] #39018: dpkg @1.14.29: update to 1.16.10

[MacPorts]

#39018: dpkg @1.14.29: update to 1.16.10
----------------------+----------------------
  Reporter:  egall@…  |      Owner:  egall@…
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:  haspatch
      Port:  dpkg     |
----------------------+----------------------

Comment (by mojca@…):

 Replying to [comment:36 xeron.oskom@…]:
 > Thank you for review.
 >
 > Replying to [comment:33 mojca@…]:
 > > Is this expected?
 > > {{{
 > > configure: WARNING: sys/proc.h: present but cannot be compiled
 > > }}}
 >
 > Expected. But we may report it to upstream.

 Thanks.

 > In general I'm fine with your changes. Some notes:
 >
 > * I don't like some places where you're doing things like this:
 >
 > {{{
 > configure.env-append \
 >                     TAR=${prefix}/bin/gnutar
 > }}}
 >
 > it looks strange when there's only one argument. But this is up to you,
 I'm not expert in TCL and macports guidelines.

 This has nothing to do with TCL guidelines. There's a MacPorts consensus
 (also on the top of the file) which says that everything should be aligned
 to 4 spaces (if possible). The `configure.env-append` is just one
 character too long. Some developers add 4 extra spaces everywhere. Some
 break the lines. Some let it go for a few lines every now and then.

 > * I'm not sure about specifying perl 5.22. It should be working with
 older versions as well.

 Yes, it should. But the port has to be bound to one fixed version. If you
 would install the port with Perl5.16 (let's say with `perl5 +perl5.16`)
 and if you then switch to Perl 5.22 and uninstall Perl 5.16, the port will
 no longer work unless you revbump it / reinstall it. You could give users
 the choice and provide variants. Which adds extra complications. See also
 #48365 (or #46570 whose main intention might no longer be desired).
 There's a lot of mess with these Perl ports and maybe we'll resolve that
 mess one day. Until then we need to make sure that ports are left in
 consistent state.

 > * I don't understand where have you seen {{{p${perl5.major}-scalar-list-
 utils}}}, I don't see this dependency.

 I didn't look for this dependency, but if I try to install `sudo port -v
 -t install dpkg` and if you have scalar-list-utils installed (correspoding
 to the version of Perl that dpkg i using), then the trace mode complains
 that two of its files have been hidden. This means that installation
 scripts tried to access that module at some point.

 > * We probably need to add {{{lzma}}} to build dependencies (we specify
 {{{--with-liblzma}}} for configuration) and {{{xz}}} to general or run
 dependencies.

 Maybe I need some further explanation here.
   * Why would you need any other port than `xz`? `xz-devel` says "this
 port is only a stub and has been made obsolete by xz".
   * If you add `xz` to `depends_lib`, there is no need for a separate
 `depends_build` and `depends_run`. Either you only provide `depends_build`
 and/or `depends_run` (provided that there is no linking involved) or you
 provide just `dependes_lib` which implies both other dependency types.
   * I admit that I don't understand the exact difference between `lzma`
 and `xz`. Which port provides whatever `--with-liblzma` needs? `xz` or
 `lzma`? Does the binary link against `lzma`/`xz`?
   * I see
 {{{
 lzma seems to have been updated (port version: 4.65, new version: 15.12)
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/39018#comment:38>
MacPorts <https://www.macports.org/>
Ports system for OS X