[MacPorts] #52365: phantomjs @2.0.0: failing to build in macOS Sierra (was: phantomjs: failing to build in OSX Sierra)

[MacPorts]

#52365: phantomjs @2.0.0: failing to build in macOS Sierra
----------------------------+----------------------
  Reporter:  andre.david@…  |      Owner:  stromnov
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.3.4
Resolution:                 |   Keywords:  sierra
      Port:  phantomjs      |
----------------------------+----------------------
Changes (by ryandesign):

 * cc: inkydaddy0923, ryandesign (added)


Comment:

 Has duplicate #53919.

 Replying to [comment:6 ioquatix]:
 > I think the solution here is to simply update the Portfile to version
 2.1 which doesn't appear to have this problem.

 This ticket is about the build failure on Sierra. Updating to 2.1.1 is
 tracked separately, in #51965.

 Replying to [comment:5 ioquatix]:
 > It looks like because of this
 >
 > {{{
 >     if ! /usr/bin/xcrun -find xcrun >/dev/null 2>&1; then
 >         echo >&2
 >         echo "   Xcode not set up properly. You may need to confirm the
 license" >&2
 >         echo "   agreement by running /usr/bin/xcodebuild without
 arguments." >&2
 >         echo >&2
 >         exit 2
 >     fi
 > }}}
 >
 > in src/qt/qtbase/configure
 >
 > I could fix it by changing to
 >
 > {{{
 >     if ! /usr/bin/xcrun -find xcodebuild >/dev/null 2>&1; then
 >         echo >&2
 >         echo "   Xcode not set up properly. You may need to confirm the
 license" >&2
 >         echo "   agreement by running /usr/bin/xcodebuild without
 arguments." >&2
 >         echo >&2
 >         exit 2
 >     fi
 > }}}
 >
 > and in src/qt/qtbase/mkspecs/features/mac/default_pre.prf
 >
 > {{{
 >     # Make sure Xcode is set up properly
 >     isEmpty($$list($$system("/usr/bin/xcrun -find xcodebuild
 2>/dev/null"))): \
 >         error("Xcode not set up properly. You may need to confirm the
 license agreement by running /usr/bin/xcodebuild.")
 > }}}

 This is what the developers of Qt appear to have done in the current
 version of Qt, so I feel fine with making that change in phantomjs, to
 hold us over until we can figure out how to update to a newer version.

--
Ticket URL: <https://trac.macports.org/ticket/52365#comment:10>
MacPorts <https://www.macports.org/>
Ports system for macOS