[MacPorts] #67935: openjdk11-graalvm, openjdk17-graalvm, openjdk19-graalvm: buildbot activation fails: file LICENSE_NATIVEIMAGE.txt already exists and does not belong to a registered port (was: openjdk17-graalvm: buildbot activation fails: file LICENSE_NATIVEIMAGE.txt already exists and does not belong to a registered port)

[MacPorts]

#67935: openjdk11-graalvm, openjdk17-graalvm, openjdk19-graalvm: buildbot
activation fails: file LICENSE_NATIVEIMAGE.txt already exists and does not
belong to a registered port
-------------------------------------------------+-------------------------
  Reporter:  mascguy                             |      Owner:  breun
      Type:  defect                              |     Status:  assigned
  Priority:  Normal                              |  Milestone:
 Component:  ports                               |    Version:  2.8.1
Resolution:                                      |   Keywords:
      Port:  openjdk11-graalvm,                  |
  openjdk17-graalvm, openjdk19-graalvm           |
-------------------------------------------------+-------------------------
Changes (by ryandesign):

 * port:  openjdk17-graalvm => openjdk11-graalvm, openjdk17-graalvm,
     openjdk19-graalvm


Comment:

 Replying to [ticket:67935 mascguy]:
 > This occurs across-the-board, with the following error:
 >
 > {{{
 > Error: Failed to activate openjdk17-graalvm:
 > Image error:
 /Library/Java/JavaVirtualMachines/openjdk17-graalvm/Contents/Home/LICENSE_NATIVEIMAGE.txt
 > already exists and does not belong to a registered port.
 > }}}

 It's not just this file, and it's not just this port. On the buildbot
 workers, /Library/Java/JavaVirtualMachines contain directories
 openjdk11-graalvm, openjdk17-graalvm, and openjdk19-graalvm, each 80-90MB.
 Some previous version of the ports must have installed their files in a
 way that bypassed the destroot. That problem has now evidently been fixed,
 based on the fact that the activation failure message now occurs. Code
 should be added to the ports to delete these unregistered files at pre-
 activate time, and that code should be kept in the ports for one year.

 > However, this issue does not occur with GitHub CI; refer to successful
 builds via recent PR:
 >
 > [https://github.com/macports/macports-ports/pull/19623 PR 19623 -
 openjdk17-graalvm: update to 17.0.8]

 Not surprising since GitHub CI always starts from a fresh OS image on
 which MacPorts has never been installed. Buildbot workers and user
 systems, however, do not wipe themselves clean so they retain any problems
 caused by ports, which is why ports should clean up those problems.

 > Nor does the issue occur locally, based on tests by multiple users.
 (Including the reporter of this ticket.)

 That only means that these users did not install whichever problematic
 versions of these ports installed these files outside of the destroot. I
 checked the 10.11 and 10.13 buildbot workers and the file had been created
 on May 10, 2023, so I suspect if you backdate your ports collection to
 that date and then install one of these ports, it would install its files
 outside the destroot, and you would then be able to reproduce the issue
 after updating your ports collection back to the current version and
 trying to install the current versions of the ports.

-- 
Ticket URL: <https://trac.macports.org/ticket/67935#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS