[MacPorts] #68035: nmap update 7.94 WIP

[MacPorts]

#68035: nmap update 7.94 WIP
-----------------------+------------------------
  Reporter:  artkiver  |      Owner:  ghosthound
      Type:  update    |     Status:  assigned
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:
      Port:            |
-----------------------+------------------------

Comment (by ryandesign):

 Replying to [ticket:68035 artkiver]:
 > I modified the Portfile locally to reflect the update and am attaching a
 diff.

 The alignment of your checksum lines does not match the former alignment.
 Generally we want to preserve a Portfile's existing alignment when we
 update, unless we're deliberately making a whitespace-only commit to fix
 alignment issues.

 > 1. port lint --nitpick returns the following:
 >
 > {{{
 > port lint --nitpick
 > --->  Verifying Portfile for nmap
 > Warning: Line 63 should be a newline (after PortGroup)
 > --->  0 errors and 1 warnings found.
 > }}}
 >
 > I wasn't able to rectify that.

 It can be rectified exactly as stated, by adding a newline after the
 PortGroup line 62. But it is not mandatory to eliminate all lint warnings;
 they're only warnings, not errors, and in this case only appear in nitpick
 mode. This lint warning was originally created back when portgroups were
 only included at the top of the Portfile. The idea was that the Portfile
 should begin with the Subversion `$Id$` comment (removed after we moved to
 GitHub in 2016), the modeline, a blank line, the PortSystem line, any
 PortGroup lines, a blank line, and then the name, version, etc. The blank
 line after the PortGroup line is often omitted when it appears later in
 the Portfile, such as within a variant or subport. Maybe the lint warning
 should not appear for such later uses.

 > Stranger, after install completes, if I invoke nmap -V it still returns
 7.93. o.O

 It is surprisingly common for developers to forget to update their version
 numbers prior to release. If that were the case here, we should add a
 patch for whatever upstream commit fixed it, and if upstream had not fixed
 it, we would report it to them.

 However, I cannot reproduce this issue.

 {{{
 % sudo port install
 --->  Computing dependencies for nmap
 --->  Fetching archive for nmap
 --->  Attempting to fetch nmap-7.94_0+pcre+ssl.darwin_21.x86_64.tbz2 from
 https://packages.macports.org/nmap
 --->  Fetching distfiles for nmap
 --->  Attempting to fetch nmap-7.94.tar.bz2 from https://nmap.org/dist/
 --->  Verifying checksums for nmap
 --->  Extracting nmap
 --->  Configuring nmap
 --->  Building nmap
 --->  Staging nmap into destroot
 --->  Installing nmap @7.94_0+pcre+ssl
 --->  Deactivating nmap @7.93_0+pcre+ssl
 --->  Cleaning nmap
 --->  Activating nmap @7.94_0+pcre+ssl
 --->  Cleaning nmap
 --->  Scanning binaries for linking errors
 --->  No broken files found.
 --->  No broken ports found.
 --->  Some of the ports you installed have notes:
   nmap has the following notes:
     Zenmap is now provided by a separate port.
 % nmap -V
 Nmap version 7.94 ( https://nmap.org )
 Platform: x86_64-apple-darwin21.6.0
 Compiled with: nmap-liblua-5.4.4 openssl-3.1.2 libssh2-1.11.0 libz-1.3
 libpcre-8.45 libpcap-1.10.4 nmap-libdnet-1.12 ipv6
 Compiled without:
 Available nsock engines: kqueue poll select
 }}}

-- 
Ticket URL: <https://trac.macports.org/ticket/68035#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS