[MacPorts] #68233: mplayer @1.5.0_0: consider adding libdvdread support

[MacPorts]

#68233: mplayer @1.5.0_0:  consider adding libdvdread support
-------------------------------------+----------------------
  Reporter:  cybertosher             |      Owner:  kencu
      Type:  request                 |     Status:  assigned
  Priority:  Normal                  |  Milestone:
 Component:  ports                   |    Version:
Resolution:                          |   Keywords:
      Port:  mplayer, mplayer-devel  |
-------------------------------------+----------------------

Comment (by ryandesign):

 Replying to [comment:3 kencu]:
 > all of these options are disabled by default:
 >
 > {{{
 > 3dfx aa alsa apple-ir arts bl bluray caca cddb cdparanoia dart dga1 dga2
 direct3d directfb \
 > directx dvb dvdnav dvdread dxr2 dxr3 esd faac faad fbdev ggi gif gui
 jack joystick kai kva \
 > ladspa liba52 libbs2b libdca libdv libnut libvorbis lirc live macosx-
 finder mad mga mng \
 > mpg123 musepack nas nemesi ossaudio pulse pvr qtx quartz radio  radio-
 capture  s3fb sdl \
 > sgiaudio smb sndio sunaudio svga tdfxfb tdfxvid theora toolame  tv-
 bsdbt848 tv-dshow \
 > tv-v4l1 tv-v4l2 twolame v4l2 vdpau vesa vidix vstream wii win32dll
 win32waveout x11 \
 > x264 xmga xmms xv xvid xvmc xvr100 zr
 > }}}

 If you mean they're disabled by default in the mplayer build system, then
 that is by itself not good justification for eliminating the ability to
 use them in MacPorts. It may not even be a good justification for turning
 those features off by default in MacPorts. MacPorts priorities are not
 always aligned with those of the upstream projects.

 > I am reluctant to start back down the unsustainable path of adding a
 large number of variants back in again, and prefer to have one clean port
 with a reasonable set of defaults.

 "Defaults" is the wrong word there. It implies there is a method for the
 user to override those defaults. The method to do that in MacPorts is
 variants, and, after the cleanup, this port doesn't have such variants.
 Offering a reasonable set of defaults with a way for the user to override
 them is great.

 > Most MacOS systems don't come with dvd drives any longer, but I'll see
 if there is a role for dvd support for disc images or similar.

 But users can purchase external USB DVD drives, and older computers, on
 which MacPorts still runs, have internal DVD drives.

 > You can set up your own copy of the mplayer port easily in your own
 local repository <https://guide.macports.org/chunked/development.local-
 repositories.html> and adjust the portfile to your own liking quite
 easily. The mplayer portfile has been simplified now to the point where it
 is quite approachable for your own desired customizatons.

 Developers can copy Portfiles and customize them, hopefully in
 anticipation of contributing their changes back to us, but modifying
 Portfiles is not something users should need to do in the normal course of
 using MacPorts. If they do, it means something is missing from the
 Portfile that should be added.

 I don't know how vital it is to add DVD support to mplayer, but it doesn't
 seem like it should be too much of an imposition to add a non-default dvd
 variant to do that.

-- 
Ticket URL: <https://trac.macports.org/ticket/68233#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS