[macruby-changes] [688] MacRuby/trunk

[source_changes at macosforge.org]

Revision: 688
          http://trac.macosforge.org/projects/ruby/changeset/688
Author:   lsansonetti at apple.com
Date:     2008-10-30 17:28:11 -0700 (Thu, 30 Oct 2008)
Log Message:
-----------
adding some XXX comments

Modified Paths:
--------------
    MacRuby/trunk/encoding.c
    MacRuby/trunk/objc.m

Modified: MacRuby/trunk/encoding.c
===================================================================
--- MacRuby/trunk/encoding.c	2008-10-30 05:04:05 UTC (rev 687)
+++ MacRuby/trunk/encoding.c	2008-10-31 00:28:11 UTC (rev 688)
@@ -35,6 +35,9 @@
 
     __encodings = CFDictionaryCreateMutable(NULL, 0, NULL, NULL);
     
+    /* XXX CFStringGetListOfAvailableEncodings() is a costly call and should
+     * be called on demand and not by default when the interpreter starts.
+     */
     e = CFStringGetListOfAvailableEncodings();
     while (e != NULL && *e != kCFStringEncodingInvalidId) {
 	VALUE iana;

Modified: MacRuby/trunk/objc.m
===================================================================
--- MacRuby/trunk/objc.m	2008-10-30 05:04:05 UTC (rev 687)
+++ MacRuby/trunk/objc.m	2008-10-31 00:28:11 UTC (rev 688)
@@ -3337,6 +3337,9 @@
     rb_define_global_function("load_bridge_support_file", rb_objc_load_bs, 1);
 
     {
+	/* XXX timer_cb should acquires the GL or not be triggered when 
+	 * MacRuby.framework is loaded in an existing Objective-C app.
+	 */
 	CFRunLoopTimerRef timer;
 	timer = CFRunLoopTimerCreate(NULL,
 		CFAbsoluteTimeGetCurrent(), 0.1, 0, 0, timer_cb, NULL);
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macruby-changes/attachments/20081030/baee8526/attachment.html>