[macruby-changes] [1529] MacRuby/branches/experimental/spec

source_changes at macosforge.org source_changes at macosforge.org
Mon May 4 13:55:33 PDT 2009


Revision: 1529
          http://trac.macosforge.org/projects/ruby/changeset/1529
Author:   eloy.de.enige at gmail.com
Date:     2009-05-04 13:55:33 -0700 (Mon, 04 May 2009)
Log Message:
-----------
Rewrote some encoding specs a bit to use a set of encodings which every implementation probably has.

Modified Paths:
--------------
    MacRuby/branches/experimental/spec/TODO
    MacRuby/branches/experimental/spec/frozen/core/encoding/aliases_spec.rb
    MacRuby/branches/experimental/spec/frozen/core/encoding/default_external_spec.rb
    MacRuby/branches/experimental/spec/frozen/core/encoding/default_internal_spec.rb

Modified: MacRuby/branches/experimental/spec/TODO
===================================================================
--- MacRuby/branches/experimental/spec/TODO	2009-05-04 20:55:20 UTC (rev 1528)
+++ MacRuby/branches/experimental/spec/TODO	2009-05-04 20:55:33 UTC (rev 1529)
@@ -1,3 +1,6 @@
+* For IO: internal_encoding returns nil when none is given and
+  Encoding.default_internal is nil or when Encoding.default_internal and
+  Encoding.default_external are the same.
 * Merge eigenclass spec into metaclass spec
 * Cleanup MacRuby specs
 * Write more 1.9/MacRuby encoding specs

Modified: MacRuby/branches/experimental/spec/frozen/core/encoding/aliases_spec.rb
===================================================================
--- MacRuby/branches/experimental/spec/frozen/core/encoding/aliases_spec.rb	2009-05-04 20:55:20 UTC (rev 1528)
+++ MacRuby/branches/experimental/spec/frozen/core/encoding/aliases_spec.rb	2009-05-04 20:55:33 UTC (rev 1529)
@@ -1,8 +1,11 @@
 require File.dirname(__FILE__) + '/../../spec_helper'
 
 describe "Encoding.aliases" do
-  it "returns a hash where the keys are the aliases and the values the real encoding name" do
+  it "returns a hash" do
     Encoding.aliases.should be_kind_of(Hash)
+  end
+
+  it "returns an encoding name for a given alias" do
     Encoding.aliases["BINARY"].should == "ASCII-8BIT"
   end
 end

Modified: MacRuby/branches/experimental/spec/frozen/core/encoding/default_external_spec.rb
===================================================================
--- MacRuby/branches/experimental/spec/frozen/core/encoding/default_external_spec.rb	2009-05-04 20:55:20 UTC (rev 1528)
+++ MacRuby/branches/experimental/spec/frozen/core/encoding/default_external_spec.rb	2009-05-04 20:55:33 UTC (rev 1529)
@@ -16,20 +16,30 @@
   end
 
   it "takes an Encoding instance" do
-    encoding = Encoding.find('macRoman')
-    Encoding.default_external = encoding
-    Encoding.default_external.name.should == 'macRoman'
+    Encoding.default_external = Encoding.find('UTF-8')
+    Encoding.default_external.name.should == 'UTF-8'
+
+    Encoding.default_external = Encoding.find('US-ASCII')
+    Encoding.default_external.name.should == 'US-ASCII'
   end
 
   it "takes a string name of an encoding" do
-    Encoding.default_external = 'macRoman'
-    Encoding.default_external.name.should == 'macRoman'
+    Encoding.default_external = 'UTF-8'
+    Encoding.default_external.name.should == 'UTF-8'
+
+    Encoding.default_external = 'US-ASCII'
+    Encoding.default_external.name.should == 'US-ASCII'
   end
 
   it "assigns the default external encoding to be used for IO" do
-    Encoding.default_external = 'macRoman'
+    Encoding.default_external = 'UTF-8'
     open(__FILE__) do |file|
-      file.external_encoding.name.should == 'macRoman'
+      file.external_encoding.name.should == 'UTF-8'
     end
+
+    Encoding.default_external = 'US-ASCII'
+    open(__FILE__) do |file|
+      file.external_encoding.name.should == 'US-ASCII'
+    end
   end
 end

Modified: MacRuby/branches/experimental/spec/frozen/core/encoding/default_internal_spec.rb
===================================================================
--- MacRuby/branches/experimental/spec/frozen/core/encoding/default_internal_spec.rb	2009-05-04 20:55:20 UTC (rev 1528)
+++ MacRuby/branches/experimental/spec/frozen/core/encoding/default_internal_spec.rb	2009-05-04 20:55:33 UTC (rev 1529)
@@ -7,25 +7,44 @@
 end
 
 describe "Encoding.default_internal=" do
+  before :all do
+    @before = Encoding.default_external
+    Encoding.default_external = 'ISO-8859-1'
+  end
+
+  after :all do
+    Encoding.default_external = @before
+  end
+
   after :each do
     Encoding.default_internal = nil
   end
 
   it "takes an Encoding instance" do
-    encoding = Encoding.find('macRoman')
-    Encoding.default_internal = encoding
-    Encoding.default_internal.name.should == 'macRoman'
+    Encoding.default_internal = Encoding.find('UTF-8')
+    Encoding.default_internal.name.should == 'UTF-8'
+
+    Encoding.default_internal = Encoding.find('US-ASCII')
+    Encoding.default_internal.name.should == 'US-ASCII'
   end
 
   it "takes a string name of an encoding" do
-    Encoding.default_internal = 'macRoman'
-    Encoding.default_internal.name.should == 'macRoman'
+    Encoding.default_internal = 'UTF-8'
+    Encoding.default_internal.name.should == 'UTF-8'
+
+    Encoding.default_internal = 'US-ASCII'
+    Encoding.default_internal.name.should == 'US-ASCII'
   end
 
-  it "assigns the default internal encoding to be used for IO" do
-    Encoding.default_internal = 'macRoman'
+  it "assigns the default external encoding to be used for IO" do
+    Encoding.default_internal = 'UTF-8'
     open(__FILE__) do |file|
-      file.internal_encoding.name.should == 'macRoman'
+      file.internal_encoding.name.should == 'UTF-8'
     end
+
+    Encoding.default_internal = 'US-ASCII'
+    open(__FILE__) do |file|
+      file.internal_encoding.name.should == 'US-ASCII'
+    end
   end
 end
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.macosforge.org/pipermail/macruby-changes/attachments/20090504/acc37580/attachment-0001.html>


More information about the macruby-changes mailing list