[MacRuby-devel] Bugfix

[Eloy Duran]

Hey,

The test looks good to me and I totally agree, false is more  
unexpected then nil in this case.

So then I looked up the tests for it from extlib:
http://github.com/sam/extlib/blob/2bc2e8a42c7a49e2e5daf530c29fb2840d0e299d/spec/object_spec.rb#L29
And it doesn't even test for the case that a constant can't be found.

Anyways, I think we should copy over that existing test and add an  
extra one for when a constant can't be looked up.
In cases/hotcocoa/object_ext_test.rb.

Also, Alexander, you might want to take those changes and tests  
upstream back to extlib.

Cheers,
Eloy

On 21 jan 2009, at 23:33, Vincent Isambart wrote:

> Hey,
>
> Attached a patch with the fix. I checked the test and the fix does  
> indeed make it pass.
> In my change I also changed Object#full_const_get to return nil (and  
> not false) when it does not find a constant because false seemed odd  
> to me. What do you think?
>
> Cheers
>
> <0001-Fixed-HotCocoa-mapping-after-framework- 
> load.patch>_______________________________________________
> MacRuby-devel mailing list
> MacRuby-devel at lists.macosforge.org
> http://lists.macosforge.org/mailman/listinfo.cgi/macruby-devel