[MacRuby-devel] [MacRuby] #410: Readline merge to the recent CRuby's.

[MacRuby]

#410: Readline merge to the recent CRuby's.
------------------------------+---------------------------------------------
 Reporter:  kouji@…           |        Owner:  lsansonetti@…        
     Type:  enhancement       |       Status:  closed               
 Priority:  blocker           |    Milestone:  MacRuby 0.5          
Component:  MacRuby           |   Resolution:  fixed                
 Keywords:  Readline          |  
------------------------------+---------------------------------------------
Changes (by lsansonetti@…):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 Thanks a lot kouji-san! I slightly modified the patch:

 rb_f_notimplement was implemented in MacRuby trunk a few days ago (no need
 to define it anymore).

 line 1492 of readline.c, I had to change the assignment from

 {{{
     rl_getc_function = (Function *) readline_getc
 }}}

 to

 {{{
     rl_getc_function = (int (*)(FILE *))readline_getc;
 }}}

 Otherwise a warning is generated by the compiler. Mac OS X uses libedit as
 the default readline implementation, and in
 /usr/include/editline/readline.h the rl_getc_function variable is defined
 as

 {{{
 extern int              (*rl_getc_function)(FILE *);
 }}}

 But Function is

 {{{
 typedef int       Function(const char *, int);
 }}}

 I didn't check with GNU readline.

-- 
Ticket URL: <http://www.macruby.org/trac/ticket/410#comment:1>
MacRuby <http://macruby.org/>