[Xquartz-changes] xserver: Branch 'master'

Jeremy Huddleston jeremyhu at freedesktop.org
Thu Aug 26 09:17:53 PDT 2010


 configure.ac          |    2 +-
 miext/damage/damage.c |    6 +-----
 2 files changed, 2 insertions(+), 6 deletions(-)

New commits:
commit e5c79d4676bc15a76d41d2bff592cf511fca1e8e
Author: Jeremy Huddleston <jeremyhu at apple.com>
Date:   Sun Aug 15 20:07:28 2010 -0700

    rootless: Remove ROOTLESS_WORKAROUND
    
    This was already removed for XWin (20701522be803fe47e921fcf059dadf64c7f287d)
    with no reported side effects.  XQuartz seems to be behaving ok without it as
    well.  While this possibly brings back bug #1168, we don't have any reproduction
    steps for that issue, and if it crops up again, we should fix it a real way
    rather than this hokey workaround which doesn't even work for COMPOSITE.
    
    This effectively reverts the following two changes:
    b2135e589baeb2ea26da50b9167feaea23bcce3c
    d7fef52254126aa5897a5c58faeda1f61d5b13d8
    
    Signed-off-by: Jeremy Huddleston <jeremyhu at apple.com>
    Reviewed-by: Jon TURNEY <jon.turney at dronecode.org.uk>

diff --git a/configure.ac b/configure.ac
index 9884fa7..95f7a76 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1926,7 +1926,7 @@ if test "x$XQUARTZ" = xyes; then
 
 	AC_CHECK_LIB([Xplugin],[xp_init],[:])
 
-	CFLAGS="${CFLAGS} -DROOTLESS_WORKAROUND -DROOTLESS_SAFEALPHA -DNO_ALLOCA"
+	CFLAGS="${CFLAGS} -DROOTLESS_SAFEALPHA -DNO_ALLOCA"
 
 	PKG_CHECK_MODULES(XPBPROXY, $APPLEWMPROTO $LIBAPPLEWM xfixes x11)
 
diff --git a/miext/damage/damage.c b/miext/damage/damage.c
index 1cf0513..e0e96f2 100644
--- a/miext/damage/damage.c
+++ b/miext/damage/damage.c
@@ -89,11 +89,7 @@ getDrawableDamageRef (DrawablePtr pDrawable)
 	ScreenPtr   pScreen = pDrawable->pScreen;
 
 	pPixmap = 0;
-	if (pScreen->GetWindowPixmap
-#ifdef ROOTLESS_WORKAROUND
-	    && ((WindowPtr)pDrawable)->viewable
-#endif
-	    )
+	if (pScreen->GetWindowPixmap)
 	    pPixmap = (*pScreen->GetWindowPixmap) ((WindowPtr)pDrawable);
 
 	if (!pPixmap)


More information about the Xquartz-changes mailing list