[Xquartz-changes] [jeremyhu/quartz-wm] fa06b4: Don't drag/resize a window if we didn't see the mo...

Ken Thomases ken at codeweavers.com
Sun Apr 22 01:54:52 PDT 2012


  Branch: refs/heads/master
  Home:   https://github.com/jeremyhu/quartz-wm
  Commit: fa06b4edc5f0f1dae9c3bfe0d63e9f5f6a85a19e
      https://github.com/jeremyhu/quartz-wm/commit/fa06b4edc5f0f1dae9c3bfe0d63e9f5f6a85a19e
  Author: Ken Thomases <ken at codeweavers.com>
  Date:   2012-04-22 (Sun, 22 Apr 2012)

  Changed paths:
    M src/x-input.m

  Log Message:
  -----------
  Don't drag/resize a window if we didn't see the mouse click event.

Quartz-wm had been interpreting MotionNotify events that indicated a button
was down as a drag or resize regardless of whether it had seen the ButtonPress
event.  However, the internal tracking state, like where the drag started, is
only initialized during the ButtonPress handler.  So, the window drag/resize
would be wildly off.

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>


  Commit: 901809d6c5ea413296d695331170315ab33659e4
      https://github.com/jeremyhu/quartz-wm/commit/901809d6c5ea413296d695331170315ab33659e4
  Author: Ken Thomases <ken at codeweavers.com>
  Date:   2012-04-22 (Sun, 22 Apr 2012)

  Changed paths:
    M src/x-input.m
    M src/x-window.h
    M src/x-window.m

  Log Message:
  -----------
  Don't decorate windows with an empty shape.

Some clients (e.g. Wine) set windows to have an empty XShape bounding region.
They may also set those windows to have decorations.  In that situation,
quartz-wm was producing weird small, black windows for what should be
invisible windows.

Reviewed-by: Jeremy Huddleston <jeremyhu at apple.com>


Compare: https://github.com/jeremyhu/quartz-wm/compare/fe83814...901809d


More information about the Xquartz-changes mailing list