[Xquartz-dev] Error viewing commit 48e6a75fbdd0fee86e364f02ace83f20b312a2b2 in gitweb

[Adam Mercer]

On Dec 6, 2007 12:02 PM, Adam Mercer <ramercer at gmail.com> wrote:

> Thanks, I'll report it upstream

I reported this problem on the GIT mailing list and it turns out its
due to freedesktop.org using a very old version of gitweb, as this
problem has been fixed in upstream gitweb.

Cheers

Adam

On Dec 8, 2007 5:49 AM, Jakub Narebski <jnareb at gmail.com> wrote:
>
> "Lars Hjemli" <hjemli at gmail.com> writes:
>
> > Actually, it's a problem in both cgit and gitweb, but you need to look
> > a bit harder to find the error in cgit. It seems that gitweb on
> > freedesktop.org doesn't detect a file rename (due to diff.renamelimit
> > maybe?), so it shows the full source of the offending files, while in
> > cgit you'll need to go from the diff to either the old or the new
> > sourcefile to get the same error:
> >
> > http://cgit.freedesktop.org/xorg/xserver/tree/hw/darwin/quartz/applewmExt.h?h=xorg-server-1.2-apple&id=141f69dc3d8d6e7d8ff65607f43700ac11243041
> > http://cgit.freedesktop.org/xorg/xserver/diff/hw/xquartz/applewm.c?h=xorg-server-1.2-apple&id=48e6a75fbdd0fee86e364f02ace83f20b312a2b2
> >
> > The problem is a number of unencoded ascii char 12.
>
> Strange... I have checked gitweb code, and esc_html used in HTML
> version of diff output escapes _all_ control characters ([:cntrl:]).
> So ASCII char 12 should be shown as \014 in "cntrl" style.
>
> Ahhh... I see, Freedesktop.org uses some ANCIENT version of gitweb,
> from before it was included in git repository.
>
> Try to ask Freedesktop.org admins to upgrade gitweb. Some nice
> features include:
>  * mod_perl compatibility
>  * ability to display binary files correctly
>  * gitweb do not use /usr/bin/diff, and do not use temporary files
>    (and supports renames, typechanges and combined diff format)
>  * better support for strange characters in contents and in pathnames
>  * very basic support for submodules
>  * snapshot support (optional)
>  * forks support (optional)
>  * 'next' links in 'commit' and 'commitdiff' view
>  * optional features: commit search, pickaxe search, snapshots
>    support,...