August 2010 - macruby-tickets - lists.macosforge.org

Re: [MacRuby] #502: Marshalling large integers returns the wrong value.
by MacRuby 16 Aug '10

16 Aug '10

#502: Marshalling large integers returns the wrong value. ------------------------------------+--------------------------------------- Reporter: jens.nockert@… | Owner: lsansonetti@… Type: defect | Status: new Priority: minor | Milestone: Component: MacRuby | Keywords: ------------------------------------+--------------------------------------- Comment(by jhemmelg@…): There were two issues with the loading of bignums in marshal. The first was that the calculation of the size of the bignum in the call to rb_big_resize() was wrong. The original code was calculating a zero size for the bignum with this test case. Therefore the loop that translates the saved bits wasn't even entered and a zero value resulted. The second issue was the commented out call to MEMZERO. With the size of the bignum now correct, this call should be reinstated to clear the bits that were not initialized from the marshalled stream. The third issue was in the loop that translated the bits. Each byte was cast to long before being shifted into place in the bignum digit. This caused a 32-bit value to be shifted by up to 56 bits with predictably whacky results. Changing the cast from (long) to (BDIGIT) fixed this. Cosmetic: There were a lot of magic number "2"s scattered around this code. As far as I can see these are actually SIZEOF_SHORT so I changed them. Side note: I found a difference in the behavior of ruby 1.9.1 and macruby when trying to Marshal.dump(1000000000). 1.9.1 dumps this as a fixnum and macruby dumps it as a bignum. I think the difference is that macruby is now using 2 bits in a VALUE instead of 1. I believe this is due to including floats as intrinsics? I don't think this is a big problem because they interoperate correctly. However, if we want to change it, line 658 in marshal.c: if (RSHIFT((long)obj, 31) == 0 || RSHIFT((long)obj, 31) == -1) { is the place. Changing the 31's to 32's makes it work the same as 1.9.1. I didn't change it because I wasn't sure how to distinguish whether 1 or 2 bits are being used to distinguish a pointer from an intrinsic. -- Ticket URL: <http://www.macruby.org/trac/ticket/502#comment:2> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #663: Kernel#sprintf formatting broken on trunk
by MacRuby 16 Aug '10

16 Aug '10

#663: Kernel#sprintf formatting broken on trunk -------------------------------------+-------------------------------------- Reporter: jordan.breeding@… | Owner: lsansonetti@… Type: defect | Status: new Priority: blocker | Milestone: MacRuby 0.6 Component: MacRuby | Keywords: -------------------------------------+-------------------------------------- Comment(by watson1978@…): Crashes When calls log10(0). Sorry. X( {{{ #!diff diff --git a/string.c b/string.c index 969cc4b..517495a 100644 --- a/string.c +++ b/string.c @@ -13,6 +13,7 @@ #include <stdarg.h> #include <wctype.h> #include <unistd.h> +#include <math.h> #include "ruby/macruby.h" #include "ruby/encoding.h" @@ -6495,7 +6496,11 @@ rb_uchar_strtol(UniChar *chars, long chars_len, long pos, long *end_offse unum_close(nf); if (end_offset != NULL) { - *end_offset = (long)parse_pos; + long offset = 0; + if(val > 0) { + offset = (long)log10((double)val); + } + *end_offset = pos + (offset + 1); // pos + size of number. } return val; } }}} -- Ticket URL: <http://www.macruby.org/trac/ticket/663#comment:2> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #663: Kernel#sprintf formatting broken on trunk
by MacRuby 16 Aug '10

16 Aug '10

#663: Kernel#sprintf formatting broken on trunk -------------------------------------+-------------------------------------- Reporter: jordan.breeding@… | Owner: lsansonetti@… Type: defect | Status: new Priority: blocker | Milestone: MacRuby 0.6 Component: MacRuby | Keywords: -------------------------------------+-------------------------------------- Comment(by watson1978@…): I think this problem to be a bug of the rb_uchar_strtol().[[BR]] When parsed the "6.2", rb_uchar_strtol() returns * returns = 6 * end_offset = 3 But, expected * returns = 6 * end_offset = 1 Too big end_offset so that does not parse ".2".[[BR]] Actually the "%6.2f" is treated with "%6f". {{{ #!diff diff --git a/string.c b/string.c index 969cc4b..cc1a735 100644 --- a/string.c +++ b/string.c @@ -13,6 +13,7 @@ #include <stdarg.h> #include <wctype.h> #include <unistd.h> +#include <math.h> #include "ruby/macruby.h" #include "ruby/encoding.h" @@ -6495,7 +6496,7 @@ rb_uchar_strtol(UniChar *chars, long chars_len, long pos, long *end_offset) unum_close(nf); if (end_offset != NULL) { - *end_offset = (long)parse_pos; + *end_offset = pos + ((long)log10((double)val) + 1); // pos + size of number. } return val; } }}} -- Ticket URL: <http://www.macruby.org/trac/ticket/663#comment:1> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #236: Array.pack bug
by MacRuby 16 Aug '10

16 Aug '10

#236: Array.pack bug ----------------------------------------+----------------------------------- Reporter: dave.baldwin@… | Owner: lsansonetti@… Type: defect | Status: closed Priority: major | Milestone: MacRuby 0.7 Component: MacRuby | Resolution: fixed Keywords: array pack | ----------------------------------------+----------------------------------- Changes (by lsansonetti@…): * status: new => closed * resolution: => fixed * milestone: => MacRuby 0.7 Comment: Thanks for checking it out. -- Ticket URL: <http://www.macruby.org/trac/ticket/236#comment:2> MacRuby <http://macruby.org/>

1 0

[MacRuby] #836: Macgem help list fails
by MacRuby 16 Aug '10

16 Aug '10

#836: Macgem help list fails --------------------------------+------------------------------------------- Reporter: cameron@… | Owner: lsansonetti@… Type: defect | Status: new Priority: minor | Milestone: Component: MacRuby | Keywords: macgem --------------------------------+------------------------------------------- When looking for all commands for macgem, I get an error and no list. {{{ $ macgem help commands Abort trap }}} -- Ticket URL: <http://www.macruby.org/trac/ticket/836> MacRuby <http://macruby.org/>

1 3

Re: [MacRuby] #236: Array.pack bug
by MacRuby 15 Aug '10

15 Aug '10

#236: Array.pack bug ----------------------------------------+----------------------------------- Reporter: dave.baldwin@… | Owner: lsansonetti@… Type: defect | Status: new Priority: major | Milestone: Component: MacRuby | Keywords: array pack ----------------------------------------+----------------------------------- Comment(by jhemmelg@…): This ticket should be closed. Tested with macirb pre-release 0.7 08/15/2010, and the problem is resolved. The results are the same for irb (1.8.7) as for macirb. macirb: 0 0 0 0 110 0 0 0 255 2 1 0 0 0 0 0 irb: 0 0 0 0 110 0 0 0 255 2 1 0 0 0 0 0 Jeff Hemmelgarn -- Ticket URL: <http://www.macruby.org/trac/ticket/236#comment:1> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #588: ld: library not found for -lLLVMBitWriter for macrubyc --static
by MacRuby 12 Aug '10

12 Aug '10

#588: ld: library not found for -lLLVMBitWriter for macrubyc --static --------------------------------+------------------------------------------- Reporter: g.vishnu@… | Owner: lsansonetti@… Type: defect | Status: reopened Priority: major | Milestone: MacRuby 0.6 Component: MacRuby | Resolution: Keywords: | --------------------------------+------------------------------------------- Changes (by jfrisby@…): * status: closed => reopened * resolution: fixed => Comment: Replying to [comment:3 lsansonetti@…]: > I believe this problem has been fixed in 0.6. It has not. I'm running OSX 10.6.4, MacRuby 0.6, and get that error. -- Ticket URL: <http://www.macruby.org/trac/ticket/588#comment:4> MacRuby <http://macruby.org/>

1 0

[MacRuby] #847: Assertion fails when calls Mutex#unlock, after calls Mutex#try_lock several times.
by MacRuby 11 Aug '10

11 Aug '10

#847: Assertion fails when calls Mutex#unlock, after calls Mutex#try_lock several times. ----------------------------------+----------------------------------------- Reporter: watson1978@… | Owner: lsansonetti@… Type: defect | Status: new Priority: blocker | Milestone: Component: MacRuby | Keywords: ----------------------------------+----------------------------------------- Test Script: {{{ #!ruby $ cat test_mutex_try_lock.rb require 'thread' m = Mutex.new p m.try_lock p m.try_lock m.unlock }}} {{{ $ macruby test_mutex_try_lock.rb true false Assertion failed: (m->thread->mutexes != Qnil), function rb_mutex_unlock0, file thread.c, line 1443. zsh: abort macruby test_mutex_try_lock.rb }}} -- Ticket URL: <http://www.macruby.org/trac/ticket/847> MacRuby <http://macruby.org/>

1 1

[MacRuby] #838: Assertion fails when use the String converted into "utf-16le".
by MacRuby 11 Aug '10

11 Aug '10

#838: Assertion fails when use the String converted into "utf-16le". ----------------------------------+----------------------------------------- Reporter: watson1978@… | Owner: lsansonetti@… Type: defect | Status: new Priority: blocker | Milestone: Component: MacRuby | Keywords: ----------------------------------+----------------------------------------- Test Script: {{{ #!ruby $ cat test_encode.rb begin "ff".encode("utf-16le").hex p "ng" rescue => e p e end begin "ff".encode("utf-16be").hex p "ng" rescue => e p e end }}} Result of Ruby 1.9.1: {{{ $ ruby test_encode.rb #<Encoding::CompatibilityError: ASCII incompatible encoding: UTF-16LE> #<Encoding::CompatibilityError: ASCII incompatible encoding: UTF-16BE> }}} Result of MacRuby Trunk: {{{ $ macruby test_encode.rb Assertion failed: (!str_is_stored_in_uchars(self)), function str_ensure_null_terminator, file string.c, line 720. zsh: abort macruby test_encode.rb }}} -- Ticket URL: <http://www.macruby.org/trac/ticket/838> MacRuby <http://macruby.org/>

1 2

Re: [MacRuby] #794: `pthread_mutex_unlock(&t->sleep_mutex)' failed: Invalid argument (22)
by MacRuby 11 Aug '10

11 Aug '10

#794: `pthread_mutex_unlock(&t->sleep_mutex)' failed: Invalid argument (22) ----------------------------------+----------------------------------------- Reporter: watson1978@… | Owner: lsansonetti@… Type: defect | Status: reopened Priority: blocker | Milestone: Component: MacRuby | Resolution: Keywords: | ----------------------------------+----------------------------------------- Changes (by lsansonetti@…): * milestone: MacRuby 0.7 => Comment: Mmh. I will have to study more this problem. I don't feel confident holding the core lock in rb_vm_thread_cancel() since it may cause deadlocks. -- Ticket URL: <http://www.macruby.org/trac/ticket/794#comment:10> MacRuby <http://macruby.org/>

1 0