August 2010 - macruby-tickets - lists.macosforge.org

Re: [MacRuby] #176: timeout fails to raise a Timeout::Error
by MacRuby 23 Aug '10

23 Aug '10

#176: timeout fails to raise a Timeout::Error ---------------------------------+------------------------------------------ Reporter: acangiano@… | Owner: lsansonetti@… Type: defect | Status: new Priority: major | Milestone: Component: MacRuby | Keywords: ---------------------------------+------------------------------------------ Comment(by watson1978@…): {{{ #!ruby $ cat t.rb require 'timeout' puts "** case 1" v = Timeout.timeout(1) { 52 } p v == 52 puts "** case 2" begin Timeout.timeout(1) { loop do 1 + 1 end } rescue Timeout::Error p :ok else p :ng end puts "** case 3" begin Timeout.timeout(1) { 1 + 1 while true } rescue Timeout::Error p :ok else p :ng end puts "** case 4" th = Thread.new {sleep 2} begin Timeout.timeout(1) {th.join} rescue Timeout::Error p :ok else p :ng end }}} I was not considering "case 4" X( {{{ $ macruby t.rb ** case 1 true ** case 2 :ok ** case 3 :ok ** case 4 terminate called after throwing an instance of 'RoxorThreadRaiseException*' zsh: abort macruby t.rb }}} -- Ticket URL: <http://www.macruby.org/trac/ticket/176#comment:7> MacRuby <http://macruby.org/>

1 0

[MacRuby] #869: Assertion failure when printing pathExtensions for an NSURL
by MacRuby 22 Aug '10

22 Aug '10

#869: Assertion failure when printing pathExtensions for an NSURL ------------------------------------+--------------------------------------- Reporter: mrada@… | Owner: lsansonetti@… Type: defect | Status: new Priority: blocker | Milestone: Component: MacRuby | Keywords: assertion NSURL pathExtension ------------------------------------+--------------------------------------- I was playing around with macirb and trying to get a collection of NSURLs to print out their pathExtension when MacRuby failed an assertion and died on me. I have been able to reproduce the issue on my system and included a small script to demonstrate the failure. -- Ticket URL: <http://www.macruby.org/trac/ticket/869> MacRuby <http://macruby.org/>

1 5

Re: [MacRuby] #430: MacRuby does not reap processes started with popen
by MacRuby 22 Aug '10

22 Aug '10

#430: MacRuby does not reap processes started with popen ---------------------------------+------------------------------------------ Reporter: neeracher@… | Owner: martinlagardette@… Type: defect | Status: new Priority: major | Milestone: Component: MacRuby | Keywords: ---------------------------------+------------------------------------------ Comment(by jhemmelg@…): This patch adds back the call to rb_syswait() which reaps the child process in io_close(). It also removes the call to kill() as this is not in 1.9.2 and doesn't seem to be necessary with this test case. I don't know what conditions prompted the inclusion of the kill() call. This test case works with the kill() call in the code as well as with it removed. Someone who knows why the kill() call was added will have to decide if it belongs in the code or not. -- Ticket URL: <http://www.macruby.org/trac/ticket/430#comment:2> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #176: timeout fails to raise a Timeout::Error
by MacRuby 21 Aug '10

21 Aug '10

#176: timeout fails to raise a Timeout::Error ---------------------------------+------------------------------------------ Reporter: acangiano@… | Owner: lsansonetti@… Type: defect | Status: new Priority: major | Milestone: Component: MacRuby | Keywords: ---------------------------------+------------------------------------------ Comment(by watson1978@…): The following patch seems to work well. {{{ #!diff diff --git a/lib/timeout.rb b/lib/timeout.rb index 297b769..274f843 100644 --- a/lib/timeout.rb +++ b/lib/timeout.rb @@ -40,11 +40,14 @@ module Timeout # Note that this is both a method of module Timeout, so you can 'include Timeout' # into your classes so they have a #timeout method, as well as a module method, # so you can call it directly as Timeout.timeout(). - def timeout(sec, klass = nil) #:yield: +sec+ + def timeout(sec, klass = nil, &block) #:yield: +sec+ return yield(sec) if sec == nil or sec.zero? exception = klass || Class.new(ExitException) begin - x = Thread.current + val = nil + x = Thread.start { + val = block.call(sec) + } y = Thread.start { begin sleep sec @@ -54,7 +57,8 @@ module Timeout x.raise exception, "execution expired" if x.alive? end } - return yield(sec) + x.join + return val rescue exception => e rej = /\A#{Regexp.quote(__FILE__)}:#{__LINE__-4}\z/o (bt = e.backtrace).reject! {|m| rej =~ m} diff --git a/thread.c b/thread.c index 6659d06..8a3e715 100644 --- a/thread.c +++ b/thread.c @@ -166,6 +166,9 @@ thread_join_m(VALUE self, SEL sel, int argc, VALUE *argv) ts.tv_sec = 0; ts.tv_nsec = 10000000; while (t->status != THREAD_DEAD) { + if (t->status == THREAD_KILLED && t->exception != Qnil) { + break; + } nanosleep(&ts, NULL); pthread_yield_np(); } diff --git a/vm.cpp b/vm.cpp index d86cc1c..6f664b3 100644 --- a/vm.cpp +++ b/vm.cpp @@ -4654,6 +4654,7 @@ rb_vm_thread_raise(rb_vm_thread_t *t, VALUE exc) // XXX we should lock here RoxorVM *vm = (RoxorVM *)t->vm; vm->push_current_exception(exc); + GC_WB(&t->exception, exc); rb_vm_thread_cancel(t); } }}} -- Ticket URL: <http://www.macruby.org/trac/ticket/176#comment:6> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #176: timeout fails to raise a Timeout::Error
by MacRuby 21 Aug '10

21 Aug '10

#176: timeout fails to raise a Timeout::Error ---------------------------------+------------------------------------------ Reporter: acangiano@… | Owner: lsansonetti@… Type: defect | Status: new Priority: major | Milestone: Component: MacRuby | Keywords: ---------------------------------+------------------------------------------ Comment(by watson1978@…): Using a patch of comment:2, "1+1 while true" loops forever within "while (t->status != THREAD_DEAD) {" (line:168, thread.c).[[BR]] Then, t->status was "THREAD_KILLED". -- Ticket URL: <http://www.macruby.org/trac/ticket/176#comment:5> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #786: MacRuby does not finish when more exceptions is generated on same Thread almost at the same time.
by MacRuby 21 Aug '10

21 Aug '10

#786: MacRuby does not finish when more exceptions is generated on same Thread almost at the same time. ----------------------------------+----------------------------------------- Reporter: watson1978@… | Owner: lsansonetti@… Type: defect | Status: new Priority: blocker | Milestone: Component: MacRuby | Keywords: ----------------------------------+----------------------------------------- Comment(by watson1978@…): Oops, I will post to #176, I mistook. Sorry. Sorry X( -- Ticket URL: <http://www.macruby.org/trac/ticket/786#comment:3> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #786: MacRuby does not finish when more exceptions is generated on same Thread almost at the same time.
by MacRuby 21 Aug '10

21 Aug '10

#786: MacRuby does not finish when more exceptions is generated on same Thread almost at the same time. ----------------------------------+----------------------------------------- Reporter: watson1978@… | Owner: lsansonetti@… Type: defect | Status: new Priority: blocker | Milestone: Component: MacRuby | Keywords: ----------------------------------+----------------------------------------- Comment(by watson1978@…): Using a patch of comment:2, "1+1 while true" loops forever within "while (t->status != THREAD_DEAD) {" (line:168, thread.c).[[BR]] Then, t->status was "THREAD_KILLED". -- Ticket URL: <http://www.macruby.org/trac/ticket/786#comment:2> MacRuby <http://macruby.org/>

1 0

Re: [MacRuby] #176: timeout fails to raise a Timeout::Error
by MacRuby 21 Aug '10

21 Aug '10

#176: timeout fails to raise a Timeout::Error ---------------------------------+------------------------------------------ Reporter: acangiano@… | Owner: lsansonetti@… Type: defect | Status: new Priority: major | Milestone: Component: MacRuby | Keywords: ---------------------------------+------------------------------------------ Comment(by watson1978@…): I see. This is a difficult issue :( -- Ticket URL: <http://www.macruby.org/trac/ticket/176#comment:4> MacRuby <http://macruby.org/>

1 0

[MacRuby] #866: String#strip is broken with string of "UTF-16BE".
by MacRuby 20 Aug '10

20 Aug '10

#866: String#strip is broken with string of "UTF-16BE". ----------------------------------+----------------------------------------- Reporter: watson1978@… | Owner: lsansonetti@… Type: defect | Status: new Priority: minor | Milestone: Component: MacRuby | Keywords: ----------------------------------+----------------------------------------- {{{ #!ruby $ cat test_strip.rb p " x ".strip p " \n\r\t x \t\r\n\n ".strip p "\x00 0b0 ".force_encoding("UTF-16BE").strip p "0\x000b0 ".force_encoding("UTF-16BE").strip }}} Result of Ruby 1.9.1: {{{ $ ruby test_strip.rb "x" "x" "0b0 " "0b0 " }}} Result of MacRuby Trunk: {{{ $ macruby test_strip.rb "x" "x" "ぢ〠" "ぢ〠" }}} -- Ticket URL: <http://www.macruby.org/trac/ticket/866> MacRuby <http://macruby.org/>

1 2

Re: [MacRuby] #176: timeout fails to raise a Timeout::Error
by MacRuby 20 Aug '10

20 Aug '10

#176: timeout fails to raise a Timeout::Error ---------------------------------+------------------------------------------ Reporter: acangiano@… | Owner: lsansonetti@… Type: defect | Status: new Priority: major | Milestone: Component: MacRuby | Keywords: ---------------------------------+------------------------------------------ Comment(by lsansonetti@…): I can see 2 problems. First, the {{{1+1 while true}}} expression will never trigger a pthread cancelation point, which means it can't be interrupted (and timeout.rb uses thread cancelation). Second, it looks like current timeout.rb doesn't even cancel {{{loop { 1+1 }}}} which triggers cancelation points. Your patch seems to fix the second problem. I don't believe the first problem is even fixable with the current macruby implementation. -- Ticket URL: <http://www.macruby.org/trac/ticket/176#comment:3> MacRuby <http://macruby.org/>

1 0