[46020] trunk/dports/_resources/port1.0/group/kde4-1.0.tcl

[Orville Bennett]

On Jan 27, 2009, at 1:02 PM, Ryan Schmidt wrote:

>
> On Jan 27, 2009, at 06:29, illogic-al at macports.org wrote:
>
>> Revision: 46020
>>          http://trac.macports.org/changeset/46020
>> Author:   illogic-al at macports.org
>> Date:     2009-01-27 04:29:50 -0800 (Tue, 27 Jan 2009)
>> Log Message:
>> -----------
>> Let's build docs by default
>>
>> Modified Paths:
>> --------------
>>    trunk/dports/_resources/port1.0/group/kde4-1.0.tcl
>>
>> Modified: trunk/dports/_resources/port1.0/group/kde4-1.0.tcl
>> ===================================================================
>> --- trunk/dports/_resources/port1.0/group/kde4-1.0.tcl	2009-01-27  
>> 11:52:14 UTC (rev 46019)
>> +++ trunk/dports/_resources/port1.0/group/kde4-1.0.tcl	2009-01-27  
>> 12:29:50 UTC (rev 46020)
>> @@ -40,8 +40,11 @@
>> configure.compiler      gcc-4.2
>>
>> configure.args-append   -DBUILD_SHARED_LIBS=ON \
>> +                        -DBUILD_doc=OFF \
>>                         -DKDE_DISTRIBUTION_TEXT="MacPorts\/Mac OS X"
>>
>> +default_variants        +docs
>> +
>> variant docs description "Install documentation" {
>>     depends_lib             port:doxygen
>>     configure.args-append   -DBUILD_doc=ON
>
> You should not use default variants in this way. How would a user  
> turn off documentation if they did not want it? The user could "sudo  
> port install foo -docs" but as soon as they need to upgrade foo, "- 
> docs" will disappear (MacPorts never records negative variants) and  
> the +docs variant will be selected again.
>
> Either remove the docs variant and just make the documentation build  
> always, or if there is value in letting the user remove the  
> documentation, then make it a (non-default) no_docs variant that  
> does so.
Hmm. OK. I've changed it just now. Need to modify the rest of my  
portfiles as well then.