[MacRuby-devel] [MacRuby] #810: MacRuby can't install the nokogiri of rubygems.

[Laurent Sansonetti]

Hi Aaron,

On Jul 24, 2010, at 3:35 PM, Aaron Patterson wrote:

> On Sat, Jul 24, 2010 at 06:46:27PM -0000, MacRuby wrote:
>> #810: MacRuby can't install the nokogiri of rubygems.
>> ----------------------------------+-----------------------------------------
>> Reporter:  watson1978@…          |        Owner:  lsansonetti@…        
>>     Type:  defect                |       Status:  closed               
>> Priority:  blocker               |    Milestone:                       
>> Component:  MacRuby               |   Resolution:  invalid              
>> Keywords:                        |  
>> ----------------------------------+-----------------------------------------
>> Changes (by lsansonetti@…):
>> 
>>  * status:  new => closed
>>  * resolution:  => invalid
>> 
>> 
>> Comment:
>> 
>> It's a bug of Nokogiri (in Ruby 1.9, #include <ruby/st.h> must be used
>> instead of #include <st.h>. I reported this problem a few months ago to
>> the maintain who fixed it in top-of-tree, but it still has not been
>> released as a new gem yet.
> 
> Actually, we've fixed this months ago:
> 
>  http://github.com/tenderlove/nokogiri/commit/602720e6
> 
> The problem is that MacRuby doesn't have a HAVE_RUBY_ENCODING_H
> constant.  In Ruby 1.8, the correct thing is to include "st.h".  In 1.9,
> we must include "ruby/st.h".  The way we determine which to use is by
> looking for HAVE_RUBY_ENCODING_H.  HAVE_RUBY_ENCODING_H is defined in
> 1.9, but not in 1.8.

Indeed! I thought that the fix didn't actually make into a gem release yet, but I was mistaken. I am going to work on making sure nokogiri builds fine with MacRuby now, I re-opened the ticket #810.

Thanks for commenting :)

Laurent