[Xquartz-dev] ah-HAH! the precise problem here is … (Re: I got it working, but still potential problem (Re: Getting bad DISPLAY value during use of 2.6.1-2.6.2 (not with 2.6.0 & before).)

[SciFi]

Hello,

Apparently the only thing I need to change
in your newer Xquartz versions
is to do this patch:

$ cd /opt/X11/lib/X11/xinit/privileged_startx.d

--- start patch ---
--- ../original/10-tmpdirs	2011-04-25 18:48:26 -0500
+++ ./10-tmpdirs	2011-04-26 01:00:36 -0500
@@ -30,7 +30,7 @@
 for dir in /tmp/.ICE-unix /tmp/.X11-unix /tmp/.font-unix ; do
 	# Use mktemp rather than mkdir to avoid possible security issue
 	# if $dir exists and is a symlink
-	if mktemp -d ${dir} >& /dev/null ; then
+	if /usr/bin/mktemp -d ${dir} >& /dev/null ; then
 		chmod 1777 $dir
 		chown root:wheel $dir
 	fi
--- end patch ---

i.e. hard-code the path for mktemp to use Apple's *BSD version.

I could not see any other usage differences between *BSD's tools and GNU-coreutils's.
(I think I scanned all of your /bin/sh scripts, but other types of scripts I could not tell, nor the compiled binaries.)

However, this patch _did_ fix the 2nd problem I was having.
Making this simple change would likely prevent your -DFAIL_HARD from occurring so much.

(After al, almost all other scripts you have, are using similar full paths. ;) )

To refresh:

The 1st problem was having to "fix" the mis-spelled DISPLAY string that I was having for some reason.  I ended-up moving-away Apple's Launch* plists for its version of X11, leaving the Xquartz plists to insert the "correct" DISPLAY string.  I would think a "launchctl unload -w" of Apple's plists might do the same trick -- if you would consider adding such lines to the Xquartz (installer?) scripts in the correct place, then we could test it.  (If you want something de-activated, then do it!  Don't leave it up to some "I am first" type trick. ;) )  As for removing Xquartz and re-enabling Apple's X11, a "launchctl load -w" of Apple's plists should be run, I would think.

I need to ask if you would rather me open a bug-report along these lines, then we could officially keep track of these modifications?

Thank you.